Project Peer review checklist V1.1.doc

Project Peer review checklist V1.1it is a check list for the software develep team to manage the Quality of the code. Case Desc: _lt;--- here the onwner of the case should put the case description ---_gt; Status(to be filled by developer) Category FS _ Items 1 Go thourgh the FS details carefully . 2 Complete Tested the new function which is match with the FS requirements. 3 Double check the FS before commit new code into VSS. If Check out the latest code before do the code change or Merge new function into e_isting 1 application. 2 Do compare the files in local and in the VSS before we commit the new files to VSS. Before Check in, check if the file’s latest chenged date time is later than the date time 3 you check out; If so, the file you changed and want to check in is not the latest one. Any _ML Config files change? If so,Compare the difference are correct between old Version 1 and new updated Version! 1 Remove Testing _amp; Debuging code like: alert() 2 Is there any JavaScript Error on each of the page? Espically the page you modified!? 1 Remove Testing _amp; Debuging code like:system.out.println statement. 2 Check the save button function, after change the UI 3 If some fields are disabled, will effect the save function. 4 For new variables or Objects, if handed ‘null’ in the code. 5 Special characters(like ‘_amp;’, ‘/’, ‘;’, etc.) handling 6 Code Performance is good or not. 7 If new parameter transfer between objects or Pages, is it clash with others? Method name changed? If so, 8 - make sure the files which call this method is also been changed reviewer(to be filled by developer) VSS _ML Config JavaScript JAVA _amp; JSP Checklist it is a check list for the software develep team to manage the Quality of the code. 9 10 11 12 1 2 3 4 5 SQL _amp; Package 6 7 8 9 10 11 12 13 1 1 2 BIRT DB Schema CMD java file name changed? If so, make sure changes in the config files must be done. ---For e_ample,someone change the method name SaveRepalceRules to saveRepalceRules in the InventoryConfigSvcImpl,but he/she didn’t change the conte_t.setCriteria(;SaveRepalceRules;) in the SaveRepalceRulesCmd,then the server will can’t find this method. Java is case sensitive. Page UI/Function changed? If so, Each button _amp; Hypelink working fine? Does the form name changed in JSP? If so, Each button _amp; Hypelink working fine? JDK 1.4 Version? Inserting data into the tables,first should insert the data into the table which have the Foreign key. When use ;select _lt;Column Name_gt; into _lt;Variable_gt; from _lt;Table Name_gt; where _lt;Filter_gt;;, make sure there is only one record for this filter. Remove Testing _amp; Debuging code:like DBMS_OUTPUT.PUT_LIN() In Query, If using NVL For Numercial column to avoid data error. Special characters(like ‘_amp;’, ‘/’, ‘;’, etc.) handling; Handling Capital leters in the String. Code Performance is good or not. Be careful to use inner join and right join. Sometimes innner join will filter some rows that should be displayed. The null measure value has some impact on summary. When join two large fact tables, make sure there is a key join between them to avoid cross join. Try to not use union in the SQL. Clear mention the columns’ name in the insert statement. In Procedure, N eed Commit or Rollback at the end of the SQL. The Variables’ name should be meaningful. Does the data types are correct in E_pression? Like using parseFloat… Is Primary Key or Foreign Key required? Does Table,Package/Procedure or any schema changed in database? If so, does the change also applied in the local backup database ICAMCH2? Checklist it is a check list for the software develep team to manage the Quality of the code. BI _amp; Reports Be careful to use inner join and right join. Sometimes innner join will filter some rows that should be displayed. 2 The null measure value has some impact on summary. When join two large fact tables, make sure there is a key join between them to avoid cross 3 join. 1 1 Page ‘BACK’ handling. 2 Files download, Is the file name correct? AppGeneral Functions Model Site Equipment Services Inventory 1 After save action of pup up screen, refresh the main screen. when the filed has some special character(like _amp; and _ ) not pass it through url. 2 It should submit from form. Some action make some disabled filed, check onload the screen, the filed should disabled or 3 not? js function , when loop the fileds. When the fileds_lt;%=i_gt; use i to inde_. Make sure 4 the last one and the first one is in the rang. If i is beyond the ma_ one and min one. There is error,object not find. 1.Actualized data should not be modified or deleted by any functionality. 2.For Fallout, Finance related cases, try to replicate issue with Schedule _amp; Finance Rerun and without only Finance Rerun. Sometimes when rerun the schedule, issue becomes nonreplicable. In that case we need to only rerun finance without touchin。